Ah, looks like it will require some more fun.

It should be much better now.

I see some local tests are failing, as it's generating this statement:
insert into User (name, id) values (?, ?)

User is now a keyword in H2, so the tests should be adapted in the model: use @Table to have it generate a different table name.

@Sanne yeah I'll wait for the full report. I have run the jpa-h2 one in native but apparently some others are complaining. I will adjust accordingly.

@Sanne it's now ready. The rest-client issue is totally unrelated. Quite an adventure.

@gsmet I see some failures in module quarkus-integration-test-hibernate-validator as well - are you sure they are unrelated?

e.g. io.quarkus.it.hibernate.validator.HibernateValidatorFunctionalityTest is failing and appears to also use ORM + H2:

javax.validation.ConstraintViolationException: Validation failed for classes [io.quarkus.it.hibernate.validator.orm.TestEntity] during persist time for groups [javax.validation.groups.Default, ]
List of constraint violations:[
	ConstraintViolationImpl{interpolatedMessage='must not be null', propertyPath=validatedField, rootBeanClass=class io.quarkus.it.hibernate.validator.orm.TestEntity, messageTemplate='{javax.validation.constraints.NotNull.message}'}
]
	at org.hibernate.cfg.beanvalidation.BeanValidationEventListener.validate(BeanValidationEventListener.java:140)
	at org.hibernate.cfg.beanvalidation.BeanValidationEventListener.onPreInsert(BeanValidationEventListener.java:80)
	at org.hibernate.action.internal.EntityInsertAction.preInsert(EntityInsertAction.java:214)
	at org.hibernate.action.internal.EntityInsertAction.execute(EntityInsertAction.java:100)
	at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:604)

@Sanne do you see test failures? Because I ran the whole extensions test suite and then the whole integration-tests suite locally with my latest changes in this PR.
And CI didn't report any failure for Validator either.

BTW what you pasted is normal, it's just HV being triggered.

yes I had local test failures in the validator extension - I believe I found a match on the CI logs but I might be wrong about CI.

FWIW this is how I run test locally:

mvn clean install -pl :quarkus-hibernate-orm -amd

I just double checked and don't have the same failures when running without your PR

Are you sure you are testing the latest changes? Because I just rebuilt everything in this PR and tested integration-tests/hibernate-validator and it's green. And CI agrees with me.

I can rebase and force push to get the rest client fix.

I force pushed a rebase.

I'll run it again...

CI looks happy.

sorry for not getting back to you yet :/ Having some issues with my environments(s): since I can't seem to get consistent build results locally even on "main" it's hard to say definitely how the upgrade is breaking things.

I'll try to cap this to today as I don't want to hold you for too long, but I have a strong impression that I have more issues when the H2 version is updated.

My guess is that you somehow have something inconsistent or you're not building everything that should be built.

it's finally working fine 👍
sorry for the delay

Woot, thanks!